Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove mkdirp dep #3108

Merged
merged 2 commits into from Jun 24, 2021
Merged

remove mkdirp dep #3108

merged 2 commits into from Jun 24, 2021

Conversation

jimmywarting
Copy link
Contributor

closes #3003

@xzyfer
Copy link
Contributor

xzyfer commented May 17, 2021

Thanks @jimmywarting. I'm happy to ship this if CI is happy.

@xzyfer
Copy link
Contributor

xzyfer commented May 17, 2021

Pretty sure these failures are expected.

@jimmywarting
Copy link
Contributor Author

jimmywarting commented May 25, 2021 •
edited

Not entierly sure what failed with Build bindings for Alpine releases / build (16)

nschonni
nschonni approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Alpine thing is unrelated. Not sure but I remember it being flakey initially after the previous major, and the current one anyway

@mfranzke mfranzke mentioned this pull request May 25, 2021
Closed
@xzyfer xzyfer merged commit 911d4db into sass:master Jun 24, 2021
@jimmywarting jimmywarting deleted the remove-mkdirp branch June 24, 2021 08:23
@xzyfer
Copy link
Contributor

xzyfer commented Jun 24, 2021

Appreciate all your effort. This is released in 6.0.1.

@jimmywarting
Copy link
Contributor Author

Np.

Do you want me to make a PR that uses Node's new fs.rm(path, { recursive }) instead of the devDep rimraf too?

@xzyfer
Copy link
Contributor

xzyfer commented Jun 24, 2021

Totally up to you. It's not something we plan to do but we're happy to look at a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni approved these changes

@sherrodejjohnson sherrodejjohnson sherrodejjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimmywarting @xzyfer @nschonni @sherrodejjohnson