Fix #2394: sourceMap option should have consistent behaviour #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #2501 |
render() and renderSync() should return "map" property in the results only if source map has been enabled.
saper
force-pushed
the
no-map-if-not-requested
branch
from
bc6e11a
to
8498f70
Compare
nschonni
approved these changes
Oct 24, 2019
|
This is potentially a brrakky change but I'm happy to move forward since a it's how the docs always said it worked |
|
Thanks. I hope to get documentation to the level where it can actually be used as the requirements document :) |
This was referenced Mar 6, 2021
Closed
Closed
This was referenced Mar 13, 2021
Closed
This was referenced Mar 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
render() and renderSync() should return "map" property in the results
only if source map has been enabled.