This repository was archived by the owner on Jul 24, 2024. It is now read-only.
This repository was archived by the owner on Jul 24, 2024. It is now read-only.
node 9.6.+ crashes with custom importer test #2293
Closed
Description
- NPM version (
npm -v
):
5.7.1 - Node version (
node -v
):
v9.8.0
(alsov9.7.1, v9.6.1
) - Node Process (
node -p process.versions
):
{ http_parser: '2.7.0',
node: '9.8.0',
v8: '6.2.414.46-node.21',
uv: '1.19.2',
zlib: '1.2.8',
ares: '1.12.0',
modules: '59',
nghttp2: '1.29.0',
napi: '2',
openssl: '1.0.2n',
icu: '60.2',
unicode: '10.0',
cldr: '32.0.1',
tz: '2017c' }
- Node Platform (
node -p process.platform
):
freebsd - Node architecture (
node -p process.arch
):
ia32
(also 64-bit) - node-sass version (
node -p "require('node-sass').info"
):
# node -p "require( './' ) .info"
node-sass 4.8.2 (Wrapper) [JavaScript]
libsass 3.5.1 (Sass Compiler) [C/C++]
- npm node-sass versions (
npm ls node-sass
):
# npm ls node-sass
node-sass@4.8.2 /wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2
`-- (empty)
Observing node crashing during npm test. Node version 8 seems to be fine.
Full log:
https://gist.github.com/60940e4411e6ee3959872f513264c268
.renderSync(importer)
Stacktrace:
magic1=bbbbbbbb magic2=bbbbbbbb ptr1=0x2c4050b1 ptr2=0x0 ptr3=0x0 ptr4=0x0 ptr5=0x0 ptr6=0x0 ptr7=0x0 ptr8=0x0
==== JS stack trace =========================================
Security context: 0x2c415fdd <JSObject>#0#
1: renderSync [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/lib/index.js:425] [bytecode=0x2bed1b1d offset=204](this=0x31ea3401 <Object map = 0x5d63bb51>#1#,opts=0x33f96881 <Object map = 0x5d65154d>#2#)
2: /* anonymous */ [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/test/api.js:1551] [bytecode=0x2becdd19 offset=32](this=0x31ea4585 <Context map = 0x5d646839>#3#,done=0x33f9685d <JSFunction (sfi = 0x529de921)>#4#)
3: callFnAsync(aka callFnAsync) [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runnable.js:371] [bytecode=0x529de995 offset=23](this=0x3a48417d <undefined>,fn=0x31ea9681 <JSFunction (sfi = 0x2becd2f5)>#5#)
4: run [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runnable.js:318] [bytecode=0x529dbc3d offset=141](this=0x31ea4f51 <Test map = 0x5d6562d1>#6#,fn=0x33f9649d <JSFunction (sfi = 0x529dd261)>#7#)
5: runTest [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:443] [bytecode=0x529dd599 offset=106](this=0x2d73acf1 <Runner map = 0x5d652c55>#8#,fn=0x33f9649d <JSFunction (sfi = 0x529dd261)>#7#)
6: /* anonymous */(aka /* anonymous */) [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:549] [bytecode=0x529dd2ed offset=128](this=0x3a48417d <undefined>,err=0x3a48417d <undefined>,errSuite=0x3a48417d <undefined>)
7: arguments adaptor frame: 0->2
8: next(aka next) [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:361] [bytecode=0x529db5a9 offset=27](this=0x3a48417d <undefined>,suite=0x3a48417d <undefined>)
9: /* anonymous */(aka /* anonymous */) [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:371] [bytecode=0x529db6d9 offset=55](this=0x3a48417d <undefined>,err=0x3a48417d <undefined>)
10: arguments adaptor frame: 0->1
11: next(aka next) [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:295] [bytecode=0x529d9dc9 offset=32](this=0x3a48417d <undefined>,i=0)
12: _onImmediate [/wrkdirs/usr/ports/textproc/node-sass/work/node-sass-4.8.2/node_modules/mocha/lib/runner.js:339] [bytecode=0x529d9bc1 offset=8](this=0x33f963b5 <Immediate map = 0x5d6626c1>#9#)
13: runCallback(aka runCallback) [timers.js:763] [bytecode=0x529d9a5d offset=49](this=0x3a48417d <undefined>,timer=0x33f963b5 <Immediate map = 0x5d6626c1>#9#)
14: tryOnImmediate(aka tryOnImmediate) [timers.js:734] [bytecode=0x529d980d offset=11](this=0x3a48417d <undefined>,immediate=0x33f963b5 <Immediate map = 0x5d6626c1>#9#,oldTail=0x33f963b5 <Immediate map = 0x5d6626c1>#9#,count=1,refCount=1)
15: processImmediate [timers.js:716] [bytecode=0x529d94e5 offset=139](this=0x43104161 <process map = 0x5d6081a1>#10#)
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
[-]node 9.6.+ crashes with custom importer test[/-][+]node 9.6.+ crashes with custom async importer test[/+][-]node 9.6.+ crashes with custom async importer test[/-][+]node 9.6.+ crashes with custom importer test[/+][-]node 9.6.+ crashes with custom importer test[/-][+]node 9.6.+ crashes with custom importer test [FreeBSD][/+]saper commentedon Mar 16, 2018
Could not reproduce on Fedora 25 with node v9.6.1
saper commentedon Mar 16, 2018
C++ stack trace:
Looks like crash occurs when trying to get "map" attribute of the importer entry:
node-sass/src/custom_importer_bridge.cpp
Lines 73 to 76 in 7648fc4
What is interesting is that
returned_map
here should be aMaybe<>
.xzyfer commentedon Mar 17, 2018
I've reproduced this with LibSass 3.5.2 on Node 9.8.0 on Windows
https://ci.appveyor.com/project/sass/node-sass/build/2743/job/ek6q44qn4ekmgoj9
xzyfer commentedon Mar 17, 2018
Interesting, rebuilding a previously passing build (also 9.6.0) resulted in a failure. Using LibSass 3.5.1.
2 remaining items
xzyfer commentedon Mar 17, 2018
Able to reproduce this with nan@2.10.0 on OSX. I've filed an issues upstream nodejs/nan#755.
saper commentedon Mar 17, 2018
I am also considering a possibility that we have always had a bug in our code which just got uncovered.
[-]node 9.6.+ crashes with custom importer test [FreeBSD][/-][+]node 9.6.+ crashes with custom importer test[/+]saper commentedon Mar 17, 2018
Thank you @kkoopa - it seems to work better now!