From b1051f8a3ef5ec988729f16af057310217a7622c Mon Sep 17 00:00:00 2001 From: xzyfer Date: Wed, 24 Apr 2019 07:17:14 +1000 Subject: [PATCH] Add support for Node 12 --- .travis.yml | 3 +++ CHANGELOG.md | 4 ++++ README.md | 1 + appveyor.yml | 8 +++++++- lib/extensions.js | 1 + 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 8c7acd20b..9edf64687 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,6 +17,9 @@ jobs: - stage: platform-test node_js: "node" os: osx + - stage: platform-test + node_js: "11" + os: linux - stage: platform-test node_js: "10" os: linux diff --git a/CHANGELOG.md b/CHANGELOG.md index 006dbb9df..4590a801b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## v4.12.0 + +https://github.com/sass/node-sass/releases/tag/v4.12.0 + ## v4.11.0 https://github.com/sass/node-sass/releases/tag/v4.11.0 diff --git a/README.md b/README.md index 25fa995a0..4aa1cba48 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,7 @@ NodeJS | Minimum node-sass version | Node Module --------|--------------------------|------------ +Node 12 | 4.12+ | 72 Node 11 | 4.10+ | 67 Node 10 | 4.9+ | 64 Node 8 | 4.5.3+ | 57 diff --git a/appveyor.yml b/appveyor.yml index ed7c2f8ff..86e0ae2c3 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -73,6 +73,9 @@ - nodejs_version: 11 GYP_MSVS_VERSION: 2015 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 + - nodejs_version: 12 + GYP_MSVS_VERSION: 2015 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 install: - ps: Install-Product node $env:nodejs_version $env:platform @@ -166,7 +169,10 @@ - nodejs_version: 11 GYP_MSVS_VERSION: 2015 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 - + - nodejs_version: 12 + GYP_MSVS_VERSION: 2015 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 + install: - ps: Install-Product node $env:nodejs_version $env:platform - node --version diff --git a/lib/extensions.js b/lib/extensions.js index 47ada7166..8d365b45d 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -77,6 +77,7 @@ function getHumanNodeVersion(abi) { case 59: return 'Node.js 9.x'; case 64: return 'Node.js 10.x'; case 67: return 'Node.js 11.x'; + case 72: return 'Node.js 12.x'; default: return false; } }