Avoid adding duplicate modules when importing forwarded stylesheets #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
efficient-module-import
branch
2 times, most recently
from
e3d8ad8
to
c76197b
Compare
In Google stylesheets that imported import-only stylesheets with many forwards many of times, we were seeing Environment._globalModules grow large enough that variable accesses were a problem. This addresses that in several ways: * Forwarded modules are now ignored if the module is already being forwarded. * Module equality is more intelligent, so that shadowed and forwarded modules can be effectively de-duplicated. * If a module would be fully shadowed by a later import *and* that module has no CSS, we no longer add an empty ShadowedModule to the module list.
nex3
force-pushed
the
efficient-module-import
branch
from
c76197b
to
16439ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Google stylesheets that imported import-only stylesheets with many
forwards many of times, we were seeing Environment._globalModules grow
large enough that variable accesses were a problem. This addresses
that in several ways:
Forwarded modules are now ignored if the module is already being
forwarded.
Module equality is more intelligent, so that shadowed and forwarded
modules can be effectively de-duplicated.
If a module would be fully shadowed by a later import and that
module has no CSS, we no longer add an empty ShadowedModule to the
module list.