Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to resolve relative Node importer URLs for source maps #923

Merged
merged 2 commits into from Jan 9, 2020
Merged

Don't try to resolve relative Node importer URLs for source maps #923

merged 2 commits into from Jan 9, 2020

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jan 7, 2020

Closes #922

@nex3 nex3 requested a review from Awjin January 7, 2020 22:43
Awjin
Awjin approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@Awjin Awjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think CI is failing due to formatting.

@nex3 nex3 merged commit ca63b1b into master Jan 9, 2020
@nex3 nex3 deleted the source-map-bug branch January 9, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Awjin Awjin Awjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sourceMap issue with custom importers
2 participants
@nex3 @Awjin