Adds built-in clamp() and hypot() #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds clamp(), div(), and hypot(). * Parses -0 as a double.
nex3
requested changes
Dec 21, 2019
nex3
reviewed
Dec 23, 2019
lib/src/functions/math.dart
Outdated
| var unit1 = "${min.hasUnits ? "has units" : "is unitless"}"; | ||
| var unit2 = "${min.hasUnits ? "is unitless" : "has units"}"; | ||
| throw SassScriptException( | ||
| "$arg1 $unit1 but $arg2 $unit2. Arguments must all have units or all be unitless."); |
There was a problem hiding this comment.
I'd also include the names of the arguments in question here—it may not be obvious from context.
Also, this is a long line (the formatter won't break strings for you).
Same below.
Awjin
changed the title
Awjin
force-pushed
the
math-clamp-div-hypot
branch
from
1197452
to
28b577a
Compare
nex3
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass-spec#1500