Avoid depending on iterator.current != null.
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
Nov 7, 2019
|
@lrhn Are you planning to continue working on this? |
|
Ack, yes. I admit I had forgotten this PR existed. Sorry about that. |
With the NNBD change to Dart, it's no longer safe to rely on an iterator returning `null` when it has hit the end (or before calling `moveNext` the first time). For non-nullable element types, it will have to throw instead. This PR rewrites code that currently rely on a `null` value to recognize the end of an iterator.
nex3
reviewed
Dec 20, 2019
| } | ||
| return groups; |
There was a problem hiding this comment.
It looks like you lost this return.
There was a problem hiding this comment.
Well, doh. Caught red-handed using the Github editor :)
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the NNBD change to Dart, it's no longer safe to rely on an iterator returning
nullwhen it has hit the end (or before callingmoveNextthe first time). For non-nullable element types, it will have to throw instead.This PR rewrites code that currently rely on a
nullvalue to recognize the end of an iterator.