Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.22.8 #778

Merged
merged 2 commits into from Jul 24, 2019
Merged

Release 1.22.8 #778

merged 2 commits into from Jul 24, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 22, 2019

This doesn't contain any code changes relative to 1.22.7, but the JS
release will pick up mbullington/node_preamble.dart#16.

This doesn't contain any code changes relative to 1.22.7, but the JS
release will pick up mbullington/node_preamble.dart#16.
@nex3 nex3 requested a review from srawlins July 22, 2019 21:48
@jathak
Copy link
Member

jathak commented Jul 22, 2019

It looks like this is failing on node v8.x since url.pathToFileURL wasn't added until v10.x (the same thing is happening for sass/migrator#70)

url.pathToFileURL, which wasn't supported until Node 10.x, is now used
in node_preamble.
@nex3
Copy link
Contributor Author

nex3 commented Jul 22, 2019

Good catch, @jathak. I've limited the Node version range.

@nex3 nex3 requested a review from srawlins July 22, 2019 23:52
@nex3 nex3 merged commit 1425a43 into master Jul 24, 2019
@nex3 nex3 deleted the release branch July 24, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants