Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a factory method for creating host callable #1829

Merged
merged 6 commits into from Dec 8, 2022
Merged

Add a factory method for creating host callable #1829

merged 6 commits into from Dec 8, 2022

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Nov 17, 2022

Expose a new method so that we can have consistent function signature parsing between dart-sass and dart-sass-embedded.

sass/sass-spec#1847

@nex3 nex3 self-requested a review November 21, 2022 21:36
lib/src/callable.dart Outdated Show resolved Hide resolved
lib/src/node/compile.dart Outdated Show resolved Hide resolved
lib/src/util/function_signature.dart Outdated Show resolved Hide resolved
@nex3
Copy link
Contributor

nex3 commented Dec 8, 2022

This also seems to be blocked on dart-lang/pub#3687.

@ntkme ntkme requested a review from nex3 December 8, 2022 04:32
@nex3 nex3 merged commit e87176a into sass:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants