Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `cloneCss() clone modules that transitively contain CSS #1824

Merged
merged 2 commits into from Nov 3, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Nov 2, 2022

Previously we were only cloning modules that directly contained CSS,
but this created a problem where extensions could be added to their
shared extension store across load-css() boundaries and thereby
applied to upstream CSS.

Closes sass/sass#3322
See sass/sass-spec#1835

Previously we were only cloning modules that directly contained CSS,
but this created a problem where extensions could be added to their
*shared* extension store across `load-css()` boundaries and thereby
applied to upstream CSS.

Closes #3322
@nex3 nex3 requested a review from Goodwine November 2, 2022 21:28
@nex3 nex3 merged commit 00c3517 into main Nov 3, 2022
@nex3 nex3 deleted the shared-extension-store branch November 3, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogus "target selector not found" error with meta.load-css()
2 participants