Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev dependencies to the latest version #1795

Merged
merged 7 commits into from Sep 7, 2022

Conversation

stof
Copy link
Contributor

@stof stof commented Sep 2, 2022

No description provided.

@stof
Copy link
Contributor Author

stof commented Sep 2, 2022

Changes done in 2nd to 6th commits are about fixing errors reporting by the new analyzer rules.

@nex3
Copy link
Contributor

nex3 commented Sep 2, 2022

Can we disable the string composition lint? I think that's pretty universally making the code look worse.

@stof
Copy link
Contributor Author

stof commented Sep 2, 2022

@nex3 updated with the lint rule disabled. I also updated the sass-analysis dependency to use lints 2.0 for consistency.

@nex3 nex3 self-requested a review September 6, 2022 20:25
@nex3
Copy link
Contributor

nex3 commented Sep 6, 2022

What happened to the two disables you removed from the analysis config?

@stof
Copy link
Contributor Author

stof commented Sep 7, 2022

@nex3 as explained in the commit message removing them, those rules were part of the pedantic config but are not part of the lints recommended config. So they were ignoring rule that were not enabled in the first place.
That's a left-over of #1521

@nex3 nex3 merged commit e2f9705 into sass:main Sep 7, 2022
@nex3
Copy link
Contributor

nex3 commented Sep 7, 2022

Thanks!

@stof stof deleted the upgrade_dependencies branch September 7, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants