Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert visitor classes to mixins #1784

Merged
merged 2 commits into from Aug 19, 2022
Merged

Convert visitor classes to mixins #1784

merged 2 commits into from Aug 19, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Aug 19, 2022

No description provided.

@nex3 nex3 requested a review from jathak August 19, 2022 20:55
jathak
jathak approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something blocking a release right now? I'll need to update the migrator in order to bring this in internally, but if we're waiting on something externally, I could always just do an internal patch for the time being.

pkg/sass_api/CHANGELOG.md Outdated Show resolved Hide resolved
@nex3 @jathak
Update pkg/sass_api/CHANGELOG.md
c3f3fdf 
Co-authored-by: Jennifer Thakar <jathak@google.com>
@nex3 nex3 merged commit 98f326b into main Aug 19, 2022
@nex3 nex3 deleted the visitor-mixin branch August 19, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @jathak