Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix superselector bugs for pseudo-elements and universal selectors #1753

Merged
merged 2 commits into from Jul 22, 2022
Merged

Fix superselector bugs for pseudo-elements and universal selectors #1753

merged 2 commits into from Jul 22, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 21, 2022

@nex3 nex3 requested a review from jathak July 21, 2022 23:54
@nex3 nex3 marked this pull request as ready for review July 21, 2022 23:54
@nex3 nex3 merged commit d159d83 into main Jul 22, 2022
@nex3 nex3 deleted the superselector branch July 22, 2022 20:55
stof
stof reviewed Jul 27, 2022
View reviewed changes
lib/src/extend/functions.dart
// have the _same_ pseudo element.
//
// In addition, order matters when pseudo-elements are involved. The selectors
// before them must
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is incomplete.

This was referenced Apr 11, 2023
Closed
Closed
@connorskees connorskees mentioned this pull request May 17, 2023
Open
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nex3 @stof @jathak