Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/node from dependencies #1737

Merged
merged 1 commit into from Jul 9, 2022
Merged

Remove @types/node from dependencies #1737

merged 1 commit into from Jul 9, 2022

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jul 6, 2022

Based on comments from #1736.

It seems to be common to use "@types/node": "*" when @types/node is required.

@Goodwine
Copy link
Member

Goodwine commented Jul 8, 2022

Interestingly when using a test package with:

  "dependencies": {
    "sass": "file:../<PATH_TO_DART_SASS>/build/npm"
  },

And then compiling import * as sass from 'sass' using NodeNext module/moduleResolution I get the same typing error regardless of whether the sass' package dependency 🤔

in other words it makes no difference whether the dependency is there or not.. perhaps it'd be better to remove it all together as suggested?
The reason I think is because @types/node exists within node_modules/sass/node_modules and TS requires the typings to exist under node_modules/<> or something like that 🤔

@ntkme ntkme changed the title Loose @types/node range to allow deduplication Remove @types/node from dependencies Jul 9, 2022
@ntkme
Copy link
Contributor Author

ntkme commented Jul 9, 2022

@Goodwine I would prefer to remove it all together as well as it is more common for end users to install it themselves anyways.

@Goodwine Goodwine merged commit f611b06 into sass:main Jul 9, 2022
@ntkme ntkme deleted the types-node-version-range branch July 9, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants