Add support for :where() #1662
Add support for :where() #1662
Conversation
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ## 1.49.12 | |||
There was a problem hiding this comment.
I think this should bump the minor version, since it's effectively a new feature.
lib/src/extend/extension_store.dart
Outdated
| @@ -831,14 +831,15 @@ class ExtensionStore { | |||
| // become `.foo:not(.bar)`. However, this is a narrow edge case and | |||
| // supporting it properly would make this code and the code calling it | |||
| // a lot more complicated, so it's not supported for now. | |||
| if (innerPseudo.normalizedName != 'is' && | |||
| innerPseudo.normalizedName != 'matches') { | |||
| if (!{'is', 'matches', 'where'} | |||
There was a problem hiding this comment.
| if (!{'is', 'matches', 'where'} | |
| if (!const {'is', 'matches', 'where'} |
|
I find something weird in this PR: it seems to treat |
|
While the browser treats them differently, there aren't really any cases where the specificity difference matters from Sass's perspective. For the one place where this was previously the case (the laws of extend), we decided to tweak the spec there since the previous language led to somewhat surprising output (that would also have been more difficult to implement here). |
|
thanks. I missed the spec tweak. |
See sass/sass#3283.
See sass/sass-spec#1783.