Stop simplifying calculations in supports #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 15, 2022
lib/src/visitor/async_evaluate.dart
Outdated
| "${condition.isCustomProperty ? '' : ' '}" | ||
| "${await _evaluateToCss(condition.value)})"; | ||
| _inSupportsDeclaration = false; |
There was a problem hiding this comment.
this should restore the previous value instead of setting it to false
nex3
approved these changes
Mar 24, 2022
lib/src/value/calculation.dart
Outdated
|
|
||
| /// Like [operate], but with the internal-only [inMinMax] parameter. | ||
| /// | ||
| /// If [inMinMax] is `true`, this allows unitless numbers to be added and | ||
| /// subtracted with numbers with units, for backwards-compatibility with the | ||
| /// old global `min()` and `max()` functions. | ||
| /// | ||
| /// If [inSupportsDeclaration] is `true`, no simplification will be done. |
There was a problem hiding this comment.
I'd call this parameter simplify, since that more directly represents what it does rather than what the context is.
Also add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1652.
See sass/sass-spec#1781