Remove dead code in the stylesheet parser #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At that point, the scanner is still at the same position than the previous check for children returning a nested declaration, so it is impossible for it to be looking at children.
|
@nex3 has this PR been missed ? |
jathak
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At that point, the scanner is still at the same position than the previous check for children returning a nested declaration, so it is
impossible for it to be looking at children.
As part of my rewrite of scssphp to a more modern and more spec-compliant codebase, I ported the dart-sass parser to PHP. This dead code was reported by our static analyzer in its updated version, and my own investigation of the code makes me agree with the tool.