Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string.insert with negative indices #1598

Merged
merged 1 commit into from Jan 14, 2022
Merged

Fix string.insert with negative indices #1598

merged 1 commit into from Jan 14, 2022

Conversation

jathak
Copy link
Member

@jathak jathak commented Jan 12, 2022

@jathak jathak requested a review from nex3 January 12, 2022 23:04
nex3
nex3 reviewed Jan 14, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,7 @@
## 1.47.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be synced and added to 1.48.1

@jathak jathak merged commit e1fcbaa into main Jan 14, 2022
@jathak jathak deleted the string-insert branch January 14, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for str-insert with negative index
2 participants
@jathak @nex3