Add TypeScript type declarations to the npm package #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
type-declarations
branch
from
3f234b2
to
0ffdb53
Compare
nex3
force-pushed
the
type-declarations
branch
from
0ffdb53
to
66f98a5
Compare
jathak
approved these changes
Dec 2, 2021
| Future<String> cloneOrCheckout(String url, String ref) async { | ||
| var name = p.url.basename(url); | ||
| if (p.url.extension(name) == ".git") name = p.url.withoutExtension(name); | ||
| String cloneOrCheckout(String url, String ref, {String? name}) { |
There was a problem hiding this comment.
Is there a reason why this is no longer asynchronous?
There was a problem hiding this comment.
We need to call it from within pkg.npmAdditionalFiles.fn which doesn't support async callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13