Automatically handle absolute URLs for FileImporters #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
file-importer-absolute
branch
from
a29cbcf
to
887528e
Compare
nex3
force-pushed
the
file-importer-absolute
branch
from
887528e
to
c40e195
Compare
nex3
force-pushed
the
file-importer-absolute
branch
from
76bea61
to
c40e195
Compare
stof
reviewed
Oct 12, 2021
| @@ -27,7 +27,7 @@ class NodeToDartFileImporter extends Importer { | |||
| NodeToDartFileImporter(this._findFileUrl); | |||
|
|
|||
| Uri? canonicalize(Uri url) { | |||
| if (url.scheme != 'file' && url.scheme != '') return null; | |||
| if (url.scheme == 'file') return _filesystemImporter.canonicalize(url); | |||
There was a problem hiding this comment.
shouldn't you keep a if (url.scheme != '') return null; after that ?
There was a problem hiding this comment.
No, we want custom importers to have the ability to use custom schemes .
Awjin
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3181
See sass/sass-spec#1731