Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpolation lookahead for calculations #1500

Merged
merged 3 commits into from Sep 22, 2021
Merged

Fix interpolation lookahead for calculations #1500

merged 3 commits into from Sep 22, 2021

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 21, 2021 •
edited

@nex3 nex3 requested a review from jathak September 21, 2021 23:21
jathak
jathak approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the space in the sass-spec reference means this was run against main, rather than the PR branch.

@nex3
Copy link
Contributor Author

nex3 commented Sep 22, 2021

Good catch, I'll re-run the tests

@nex3 nex3 merged commit 8d5d586 into main Sep 22, 2021
@nex3 nex3 deleted the interpolation-lookahead branch September 22, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculations are parsed incorrectly if followed by parenthesized interpolation
2 participants
@nex3 @jathak