Fix pre-existing HintCode.UNNECESSARY_TYPE_CHECK_TRUE #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
requested changes
Sep 2, 2021
There was a problem hiding this comment.
This code is actually more complicated than it looks. Although the type check in question isn't necessary in async_evaluate.dart, that code is compiled to the synchronous evaluate.dart and transformed into a callable is Callable check which is relevant. Can you just add an ignore for the hint instead?
scheglov
force-pushed
the
fix-HintCode.UNNECESSARY_TYPE_CHECK_TRUE
branch
from
bdfaadd
to
e852901
Compare
|
Done. |
nex3
approved these changes
Sep 2, 2021
|
Could you merge these changes? It seems that I don't have corresponding permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for landing https://dart-review.googlesource.com/c/sdk/+/190360 into the analyzer.