Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider soliciting language proposal feedback via npm #1397

Closed
Awjin opened this issue Jun 15, 2021 · 3 comments
Closed

Consider soliciting language proposal feedback via npm #1397

Awjin opened this issue Jun 15, 2021 · 3 comments

Comments

@Awjin
Copy link
Contributor

Awjin commented Jun 15, 2021

The /-as-division deprecation proposal was merged in 2019 after going through the formal process of public review. The deprecation was implemented recently in Dart Sass. Although this was just a deprecation and not a breaking change, it led to cases where developers saw their builds break due to too many deprecation warnings. Several such reports were filed here: sass/sass#2565.

The most common developer frustrations seem to be:

  1. Surprise that /-as-division was being deprecated in the first place.
  2. math.div() not seeming like a good replacement for /.
  3. The inability to control deprecation warnings flooding in from upstream dependencies.

(3) is an implementation detail which we fixed, but (1) and (2) seem like they could be communication problems. Even though the Sass team solicited feedback on the proposal as it normally does, developers don't necessarily follow Sass on its public channels and only discover these proposals when their build breaks—at which point the proposals have long been discussed and merged.

We should consider adding an npm postinstall script that solicits feedback on upcoming language feature proposals. This could help widen the funnel of Sass developers who are aware of and review proposals.

@luigimannoni
Copy link

luigimannoni commented Jun 27, 2021

+1

I have recently discovered about this because of a somewhat unrelated sass git issue I was tracking, no one reads from my team reads the main blog but we seen npm postinstalls all days (cough cough, core-js).

Please do implement npm postinstall messages

@nex3 nex3 transferred this issue from sass/sass Jul 13, 2021
@nex3 nex3 self-assigned this Jul 13, 2021
@nex3
Copy link
Contributor

nex3 commented Jul 13, 2021

I got most of the way through implementing this before realizing it won't actually work: as of npm 7.x, postinstall scripts can't actually print any output to the user unless they explicitly pass a --foreground-scripts option, which we can safely assume essentially no one will pass. npm/cli#3347 indicates that this is intentional on the part of npm, so unfortunately I think this issue is infeasible.

@nex3 nex3 closed this as completed Jul 13, 2021
@Akxe

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants