Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with implicit dependencies #1348

Merged
merged 2 commits into from Jun 8, 2021
Merged

Fix a bug with implicit dependencies #1348

merged 2 commits into from Jun 8, 2021

Conversation

jathak
Copy link
Member

@jathak jathak commented Jun 7, 2021

Encountered this while migrating internal code to math.div

See sass/sass-spec#1666.

Encountered this while migrating internal code to math.div
@jathak jathak requested a review from nex3 June 7, 2021 23:23
pubspec.yaml Outdated
@@ -1,5 +1,5 @@
name: sass
version: 1.34.1
version: 1.34.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark this as a dev version until #1347 is fixed as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. There's a decent chance the other bug is also causing issues with the internal migration; I just haven't noticed it because I've been focused on this one

@jathak jathak merged commit 7545011 into master Jun 8, 2021
@jathak jathak deleted the implicit-dep-fix branch June 8, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants