Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.33.0 breaking change with laravel-mix and bootstrap #1319

Closed
greggunner opened this issue May 21, 2021 · 5 comments
Closed

1.33.0 breaking change with laravel-mix and bootstrap #1319

greggunner opened this issue May 21, 2021 · 5 comments

Comments

@greggunner
Copy link

I've had a laravel-mix project which I just updated to 1.33.0 of sass and on doing a laravel-mix build, I get an output that is filled with pages and pages of the new deprecation warning regarding the division symbol. I had to kill the process as it never ended and the output seemed to repeatedly output the same warning for the same line of code several times.

Downgrading to 1.32.13 resolved the issue and the project compiled.

software version
sass 1.33.0 compiled with dart2js 2.13.0
node 12.17.0
npm 6.14.4
laravel-mix 6.0.19
bootstrap 4.6.0
@phil-w
Copy link

phil-w commented May 21, 2021

Yeah it kills bootstrap 4 dead with that error. I would guess that my BS4 SASS files have slash in them.
As you say, never ending scrolling terminal garbage.

It's 1.33.0 wot breaks it, so presumably need to request whatever was working before that update.

The fix could be:

 yarn remove sass
 yarn add sass@1.32.12

@Awjin
Copy link
Contributor

Awjin commented May 21, 2021

Duplicate of #672

@Awjin Awjin marked this as a duplicate of #672 May 21, 2021
@Awjin Awjin closed this as completed May 21, 2021
@Awjin Awjin reopened this May 21, 2021
@Awjin
Copy link
Contributor

Awjin commented May 21, 2021

#672 is tracking the proper fix for this. For now, you can work around this by using the --quiet flag to silence the output (keep in mind that this will also mute non-deprecation @warns).

@Awjin
Copy link
Contributor

Awjin commented May 21, 2021

That being said, we should not be emitting multiple deprecation warnings for the same source line of code. This is addressed by #1322.

More broadly, we should probably add limits to the amount of warnings that can be printed. Filed an issue here: #1323.

@stof
Copy link
Contributor

stof commented May 22, 2021

@Awjin @nex3 should this be closed now, or should it wait for the 1.33.1 release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants