Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make :is() behave like :matches() #1315

Merged
merged 3 commits into from May 20, 2021
Merged

Make :is() behave like :matches() #1315

merged 3 commits into from May 20, 2021

Conversation

jathak
Copy link
Member

@jathak jathak commented May 19, 2021

@jathak jathak requested a review from nex3 May 19, 2021 23:20
@jathak
Copy link
Member Author

jathak commented May 19, 2021

Not sure what's wrong with the analyzer here

Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer is failing because of dart-lang/sdk#45488; #1312 will fix it.

CHANGELOG.md Outdated
@@ -15,6 +15,10 @@
made slash-free in both cases. This is a behavioral change, but it's unlikely
to affect any real-world stylesheets.

* [`:is()`][] now behaves identically to `:matches()`.

[`:is()`]: https://developer.mozilla.org/en-US/docs/Web/CSS/:is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to put this at the root level rather than indented to match the bullet point; although it should work either way, some Markdown processors choke on indented references.

@jathak jathak merged commit efe680e into master May 20, 2021
@jathak jathak deleted the is-like-matches branch May 20, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants