Support HWB in adjust, change, and scale #1111
Merged
+92
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Oct 13, 2020
lib/src/functions/color.dart
Outdated
Comment on lines
455
to
456
| var hasSl = saturation != null || lightness != null; | ||
| var hasWb = whiteness != null || blackness != null; |
There was a problem hiding this comment.
According to the Dart style guide, these should be hasSL and hasWB.
lib/src/functions/color.dart
Outdated
| var whiteness = getParam("whiteness", 100); | ||
| var blackness = getParam("blackness", 100); | ||
|
|
There was a problem hiding this comment.
This should assert that these parameters (but not saturation and lightness) have unit % for adjust() and change().
|
By the way, I'm looking into the grinder error in the tests. |
This adds `$whiteness` and `$blackness` parameters to the `adjust`, `change`, and `scale` functions in the color module. In doing so, I generalized the logic for all three functions into a single `_updateComponents` helper since they all shared a lot of similar logic for validating their parameters.
jathak
force-pushed
the
hwb-function-params
branch
from
8c5f8be to
ecca6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
$whitenessand$blacknessparameters to theadjust,change, andscalefunctions in the color module.In doing so, I generalized the logic for all three functions into a single
_updateComponentshelper since they all shared a lot of similar logic for validating their parameters.See sass/sass#2834
See #1089
See sass/sass-spec#1577