Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a map.deep-merge() function #1077

Merged
merged 2 commits into from Sep 15, 2020
Merged

Add a map.deep-merge() function #1077

merged 2 commits into from Sep 15, 2020

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 15, 2020

This also adds a Value.tryMap() function, which was useful for
implementing this and may be more generally useful to users as well.

See sass/sass#2836
See sass/sass-spec#1560

This also adds a Value.tryMap() function, which was useful for
implementing this and may be more generally useful to users as well.

See sass/sass#2836
See sass/sass-spec#1560
@nex3 nex3 requested a review from Awjin September 15, 2020 01:09
@nex3 nex3 mentioned this pull request Sep 15, 2020
@nex3 nex3 merged commit bc7216a into master Sep 15, 2020
@nex3 nex3 deleted the deep-merge branch September 15, 2020 20:03
@jathak
Copy link
Member

jathak commented Sep 15, 2020

Was this supposed to be merged into master or feature.nested-maps?

nex3 added a commit that referenced this pull request Sep 15, 2020
This reverts commit bc7216a.

This was intended to land on a feature branch, not on master.
nex3 added a commit that referenced this pull request Sep 15, 2020
This also adds a Value.tryMap() function, which was useful for
implementing this and may be more generally useful to users as well.

See sass/sass#2836
See sass/sass-spec#1560
nex3 added a commit that referenced this pull request Sep 15, 2020
This also adds a Value.tryMap() function, which was useful for
implementing this and may be more generally useful to users as well.

See sass/sass#2836
See sass/sass-spec#1560
nex3 added a commit that referenced this pull request Sep 15, 2020
This reverts commit 315e86b.

Once again, this was supposed to go on feature.nested-maps.
nex3 added a commit that referenced this pull request Sep 15, 2020
This also adds a Value.tryMap() function, which was useful for
implementing this and may be more generally useful to users as well.

See sass/sass#2836
See sass/sass-spec#1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants