Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in css output #1024

Closed
ghost opened this issue Jun 8, 2020 · 1 comment
Closed

Issue in css output #1024

ghost opened this issue Jun 8, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 8, 2020

Hi everyone,

I have a small issue in my compiled css file. Suppose that my scss is like this:

/*
* 1. Set base font properties.
* 2. Remove highlight color on mobile (webkit).
* 3. Improve font rendering.
* 4. Make the footer stick to the bottom of the page.
* 5. Costumize the site's scrollbar (webkit).
----------------------------------------------------*/

body {
  font: 1.8rem/1.15 fn-family(standard); /* 1 */
  background-color: color(black, bg);
  color: color(white);
  -webkit-tap-highlight-color: transparent; /* 2 */
  -webkit-font-smoothing: antialiased; /* 3 */
  -moz-osx-font-smoothing: grayscale; /* 3 */
  display: flex; /* 4 */
  flex-direction: column; /* 4 */
  height: 100%; /* 4 */
  
}

The expected output is:

/*
* 1. Set base font properties.
* 2. Remove highlight color on mobile (webkit).
* 3. Improve font rendering.
* 4. Make the footer stick to the bottom of the page.
* 5. Costumize the site's scrollbar (webkit).
----------------------------------------------------*/

body {
  font: 1.8rem/1.15 fn-family(standard); /* 1 */
  background-color: color(black, bg);
  color: color(white);
  -webkit-tap-highlight-color: transparent; /* 2 */
  -webkit-font-smoothing: antialiased; /* 3 */
  -moz-osx-font-smoothing: grayscale; /* 3 */
  display: flex; /* 4 */
  flex-direction: column; /* 4 */
  height: 100%; /* 4 */
  
}

As you can see, the same.

But the real behavior is:

/*
* 1. Set base font properties.
* 2. Remove highlight color on mobile (webkit).
* 3. Improve font rendering.
* 4. Make the footer stick to the bottom of the page.
* 5. Costumize the site's scrollbar (webkit).
----------------------------------------------------*/
body {
  font: 1.8rem/1.15 fn-family(standard);
  /* 1 */
  background-color: color(black, bg);
  color: color(white);
  -webkit-tap-highlight-color: transparent;
  /* 2 */
  -webkit-font-smoothing: antialiased;
  /* 3 */
  -moz-osx-font-smoothing: grayscale;
  /* 3 */
  display: flex;
  /* 4 */
  flex-direction: column;
  /* 4 */
  height: 100%;
  /* 4 */
}

You can cleary see that sass wrap the line comments, like they were properties.
Is this a bug?

@Awjin Awjin transferred this issue from sass/sass Jun 9, 2020
@Awjin Awjin added the duplicate label Jun 9, 2020
@Awjin
Copy link
Contributor

Awjin commented Jun 9, 2020

Duplicate of ##417

@Awjin Awjin closed this as completed Jun 9, 2020
@Awjin Awjin removed the duplicate label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant