From 586a0eb70347e45f19f0923ce05e2cb94209da88 Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Tue, 1 Oct 2019 15:05:11 -0700 Subject: [PATCH] Code review change --- dart_test.yaml | 4 ---- test/cli/shared/repl.dart | 4 ++-- test/source_map_test.dart | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dart_test.yaml b/dart_test.yaml index 0325ffd97..c28aa54eb 100644 --- a/dart_test.yaml +++ b/dart_test.yaml @@ -2,8 +2,4 @@ tags: # Indicates tests that require Node.js. node: - # Indicates tests that use the new module system, and so should only run on - # the `feature.use` branch. - module-system: - platforms: [vm, node] diff --git a/test/cli/shared/repl.dart b/test/cli/shared/repl.dart index 705b3d430..2705d3610 100644 --- a/test/cli/shared/repl.dart +++ b/test/cli/shared/repl.dart @@ -161,7 +161,7 @@ void sharedTests(Future runSass(Iterable arguments)) { await sass.kill(); }); - }, tags: "module-system"); + }); group("gracefully handles", () { test("a parse error", () async { @@ -297,7 +297,7 @@ void sharedTests(Future runSass(Iterable arguments)) { ])); await sass.kill(); }); - }, tags: "module-system"); + }); group("and colorizes", () { test("an error in the source text", () async { diff --git a/test/source_map_test.dart b/test/source_map_test.dart index 40684ebdb..8e1d24432 100644 --- a/test/source_map_test.dart +++ b/test/source_map_test.dart @@ -562,7 +562,7 @@ main() { (url) => Uri.parse("u:$url"), (_) => ImporterResult(r"$var2: default value !default;", syntax: Syntax.scss))); - }, tags: "module-system"); + }); group("a mixin argument that is", () { test("the default value", () {