diff --git a/pkg/analyzer/analyzer.go b/pkg/analyzer/analyzer.go index f06b6d6..67755e5 100644 --- a/pkg/analyzer/analyzer.go +++ b/pkg/analyzer/analyzer.go @@ -14,16 +14,16 @@ import ( ) const ( - TimeWeekdayFlag = "time-weekday" - TimeMonthFlag = "time-month" - TimeLayoutFlag = "time-layout" - CryptoHashFlag = "crypto-hash" - HTTPMethodFlag = "http-method" - HTTPStatusCodeFlag = "http-status-code" - RPCDefaultPathFlag = "rpc-default-path" - OSDevNullFlag = "os-dev-null" - SQLIsolationLevelFlag = "sql-isolation-level" - TLSSignatureScheme = "tls-signature-scheme" + TimeWeekdayFlag = "time-weekday" + TimeMonthFlag = "time-month" + TimeLayoutFlag = "time-layout" + CryptoHashFlag = "crypto-hash" + HTTPMethodFlag = "http-method" + HTTPStatusCodeFlag = "http-status-code" + RPCDefaultPathFlag = "rpc-default-path" + OSDevNullFlag = "os-dev-null" + SQLIsolationLevelFlag = "sql-isolation-level" + TLSSignatureSchemeFlag = "tls-signature-scheme" ) // New returns new usestdlibvars analyzer. @@ -48,7 +48,7 @@ func flags() flag.FlagSet { flags.Bool(RPCDefaultPathFlag, false, "suggest the use of rpc.DefaultXXPath") flags.Bool(OSDevNullFlag, false, "suggest the use of os.DevNull") flags.Bool(SQLIsolationLevelFlag, false, "suggest the use of sql.LevelXX.String()") - flags.Bool(TLSSignatureScheme, false, "suggest the use of tls.SignatureScheme.String()") + flags.Bool(TLSSignatureSchemeFlag, false, "suggest the use of tls.SignatureScheme.String()") return *flags } @@ -107,7 +107,7 @@ func run(pass *analysis.Pass) (interface{}, error) { checkSQLIsolationLevel(pass, n) } - if lookupFlag(pass, TLSSignatureScheme) { + if lookupFlag(pass, TLSSignatureSchemeFlag) { checkTLSSignatureScheme(pass, n) } diff --git a/pkg/analyzer/analyzer_test.go b/pkg/analyzer/analyzer_test.go index 9b33acc..4898d3b 100644 --- a/pkg/analyzer/analyzer_test.go +++ b/pkg/analyzer/analyzer_test.go @@ -28,7 +28,7 @@ func TestUseStdlibVars(t *testing.T) { mustNil(t, a.Flags.Set(analyzer.RPCDefaultPathFlag, "true")) mustNil(t, a.Flags.Set(analyzer.OSDevNullFlag, "true")) mustNil(t, a.Flags.Set(analyzer.SQLIsolationLevelFlag, "true")) - mustNil(t, a.Flags.Set(analyzer.TLSSignatureScheme, "true")) + mustNil(t, a.Flags.Set(analyzer.TLSSignatureSchemeFlag, "true")) analysistest.Run(t, analysistest.TestData(), a, pkgs...) }