Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal exception handler / fallback #257

Open
techalchemy opened this issue Jun 15, 2020 · 1 comment
Open

Add universal exception handler / fallback #257

techalchemy opened this issue Jun 15, 2020 · 1 comment

Comments

@techalchemy
Copy link
Member

In light of the AST parsing issues we should find a way to add universal exception handling in the AST parser to decide:

  1. when we encounter an exception, whether we need to stop trying to parse via the AST (only necessary if we are holding references we can't resolve to dependencies etc) or,
  2. Even if we don't encounter an exception, did we successfully resolve everything we need to figure out? I'm not sure how we will be able to tell but I have seen some cases where we are not resolving everything this way, and it's made me wonder if we should stop using the AST parser entirely
@frostming
Copy link
Member

IMHO we only need name information in the parsing stage(for local directory requirements) and leave other metadata be read from egg-info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants