Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #15

Closed
elite174 opened this issue Jun 9, 2022 · 8 comments
Closed

Add windows support #15

elite174 opened this issue Jun 9, 2022 · 8 comments
Labels
invalid This doesn't seem right

Comments

@elite174
Copy link

elite174 commented Jun 9, 2022

It doesn't work for windows

@sapphi-red
Copy link
Owner

CI is running for linux and windows so it should work. Also it is working on my windows PC.
Please provide a reproduction.

@sapphi-red sapphi-red added the needs more info Further information is requested label Jun 10, 2022
@elite174
Copy link
Author

Maybe the issue related to symlinks

I always get No items found. message

viteStaticCopy({
      targets: [
        {
          src: [
            path.resolve(__dirname, '../web/node_modules/@BricksInc/comp-engine-mt/engine.worker.js'),
            path.resolve(__dirname, '../web/node_modules/@BricksInc/comp-engine-mt/engine.js'),
          ],
          dest: '',
        },
      ],
    }),

the same code works for mac

@wkl007
Copy link

wkl007 commented Jun 23, 2022

may be the problem: sindresorhus/globby#179 (comment)

@sapphi-red
Copy link
Owner

sapphi-red commented Jul 3, 2022

Thanks @wkl007.

@elite174
As @wkl007 said, you need to use normalizePath. \ means escape for fast-glob.

@sapphi-red sapphi-red added invalid This doesn't seem right and removed needs more info Further information is requested labels Jul 3, 2022
@elite174
Copy link
Author

elite174 commented Jul 3, 2022

Thank you so much! It would be useful to document this thing, because it's not really obvious.

@wkl007
Copy link

wkl007 commented Jul 4, 2022

You are welcome @sapphi-red

@elite174
Copy link
Author

elite174 commented Jul 4, 2022

I tried path normalization and it doesn't work.
Seems that it doesn't work with symllinks on windows correctly, because I tried the same code under wsl and everything works as expected.

In my project I use rush monorepo manager with pnpm

@sapphi-red
Copy link
Owner

Would you create a new issue with reproduction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants