New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Node from terms.jsonrc #47
Conversation
Node word is used widely in tons of different contexts, does't make much sense to infer that it is related with Node.js Examples: - Node as part of a graph - Node as machine part of a cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still keep it to catch node.js
and nodejs
:
["Node[ .]js", "Node.js"],
Changed as request by @sapegin |
Thanks! Could you please update a failing test? |
done |
It's still failing though... |
I'm sorry, it is now fixed |
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Node word is used widely in tons of different contexts, doesn't make much sense to infer that it is related with Node.js
Examples: