Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing naming of counter metrics to comply with the Prometheus naming conventions #23

Open
5 tasks
daviddetorres opened this issue Nov 12, 2019 · 0 comments

Comments

@daviddetorres
Copy link

daviddetorres commented Nov 12, 2019

I made a PR in Prometheus documentation repository to add this exporter to the list of exporters. In the PR the revisor (@brian-brazil) pointed out some changes that would be needed to comply with the naming conventions of Prometheus metrics.

  • Add the sufix "_total" to all the counter metrics
  • Change $SYS/broker/uptime and $SYS/broker/clients/maximum to type gauge

Also would be interesting to:

The most complex here would be adding the sufix to all the counters, due to the metrics would change from the current version to this one and all the queries using this metrics would need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant