Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick code review #20

Merged
merged 2 commits into from Feb 27, 2021
Merged

Quick code review #20

merged 2 commits into from Feb 27, 2021

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Feb 21, 2021 •
edited

  • go mod tidy
  • errors.New instead of fmt.Errorf when no arguments
  • simplify switch
  • simplify nested if

sanposhiho
sanposhiho approved these changes Feb 27, 2021
View reviewed changes
Copy link
Owner

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for opening the PR.

Looks very goooood. very thanks
❤🧡💛💚💙💜🤎🖤🤍

@sanposhiho sanposhiho merged commit 1413d2f into sanposhiho:master Feb 27, 2021
@ldez ldez deleted the fix/code-review branch February 27, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldez @sanposhiho