Add missing spaces in CLI error message #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2485 +/- ##
=============================================
+ Coverage 87.269% 87.328% +0.058%
=============================================
Files 60 60
Lines 5098 5098
Branches 913 913
=============================================
+ Hits 4449 4452 +3
+ Misses 476 474 -2
+ Partials 173 172 -1
Continue to review full report at Codecov.
|
ahopkins
approved these changes
Jun 26, 2022
Tronic
reviewed
Jun 28, 2022
Comment on lines
-149
to
152
| "Module is not a Sanic app, it is a" | ||
| "Module is not a Sanic app, it is a " | ||
| f"{app_type_name}\n" | ||
| " If this callable returns a" | ||
| " If this callable returns a " | ||
| f"Sanic instance try: \n{solution}" |
There was a problem hiding this comment.
This ought to be using a single f string literal specifically to avoid this type of problem. And the line length limitation should be long enough to fit that on a single line (or allow breaking the rule for a literal).
These are just my notes for improving code quality in general (and for reconsideration of black settings), not asking for any immediate changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.