New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_cli
and test_cookies
#2479
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2479 +/- ##
=========================================
Coverage 87.267% 87.267%
=========================================
Files 60 60
Lines 5097 5097
Branches 913 913
=========================================
Hits 4448 4448
Misses 476 476
Partials 173 173 Continue to review full report at Codecov.
|
Test cookies issue seems a problem of httpx's async client. In the failed test cookie case, the headers contain setting cookie but hpptx didn't put it into |
It's weird that fixing cli tests appears increase the chance of the failed cookies test. @ahopkins |
The cookies test fixed, the only (occasionally) broken test case is keep alive. |
test_cli
and test_cookies
Amazing amazing work. You rock. |
I was able to reproduce the test cli issues on my laptop, which is the timeout occurred when running the subprocess in
capture
function. After increasing the timeout locally, the issue never came up again during multiple tests.Open this PR to further test the test cases.
I think this issue usually happen on smaller machine with lower performance.