Properly catch websocket CancelledError in websocket handler in Python 3.7 #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon 3.7. In python 3.8 `CancelledError` is subclass of `BaseException`, but in Python 3.7 and earlier, it is subclass of `Exception`. That means in python 3.7, the `CancelledError` gets caught by the general `Exception` handler, and does not correctly handle the case of a cancelled websocket task. Fixes #2462
Codecov Report
@@ Coverage Diff @@
## main #2463 +/- ##
=============================================
+ Coverage 87.176% 87.255% +0.079%
=============================================
Files 60 60
Lines 5061 5061
Branches 909 909
=============================================
+ Hits 4412 4416 +4
+ Misses 477 474 -3
+ Partials 172 171 -1
Continue to review full report at Codecov.
|
ashleysommer
changed the title
ashleysommer
changed the title
ahopkins
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.8
CancelledErroris subclass ofBaseException, but in Python 3.7 and earlier, it is subclass ofException. That means in python 3.7, theCancelledErrorgets caught by the generalExceptionhandler, and does not correctly handle the case of a cancelled websocket task.Fixes #2462