Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger http.lifecycle.request signal in ASGI mode #2451

Merged
merged 2 commits into from Jun 16, 2022
Merged

Conversation

zozzz
Copy link
Contributor

@zozzz zozzz commented May 10, 2022

I want to dispatch more signals, but i think this is currently not possible. I comment out in the test the remaining signals.

@zozzz zozzz requested a review from a team as a code owner May 10, 2022 14:16
juan-pe added a commit to Som-Energia/infoenergia-api that referenced this pull request Jun 3, 2022
deactivated sentry integration until sanic-org/sanic#2451 is resolved
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #2451 (0da9657) into main (65b53a5) will increase coverage by 0.061%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2451       +/-   ##
=============================================
+ Coverage   87.186%   87.248%   +0.061%     
=============================================
  Files           60        60               
  Lines         5065      5066        +1     
  Branches       910       910               
=============================================
+ Hits          4416      4420        +4     
+ Misses         476       474        -2     
+ Partials       173       172        -1     
Impacted Files Coverage Δ
sanic/asgi.py 88.429% <100.000%> (+0.096%) ⬆️
sanic/server/protocols/http_protocol.py 87.500% <0.000%> (+3.409%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b53a5...0da9657. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants