Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor environment variable hydration logic. #2321

Merged
merged 2 commits into from Dec 2, 2021
Merged

Refactor environment variable hydration logic. #2321

merged 2 commits into from Dec 2, 2021

Conversation

Varriount
Copy link
Contributor

  • Refactor environment variable hydration logic to be less nested.
    This allows possible future extension of the hydration logic.
  • Fix a spelling mistake in load_environment_vars's docstring.

@Varriount
Refactor environment variable hydration logic.
7db5ab9 
- Refactor environment variable hydration logic to be less nested. This allows possible future extension of the hydration logic.
- Fix a spelling mistake in `load_environment_vars` docstring.
@Varriount Varriount requested a review from a team as a code owner November 24, 2021 22:44
ahopkins
ahopkins reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It seems the code change is mainly stylistic, unless as you say, there were a method to extend that. I suppose that's the question, should we add an api for extension the same way you can extend path parameter types?

@ahopkins ahopkins self-requested a review December 2, 2021 21:29
@ahopkins ahopkins merged commit f641830 into sanic-org:main Dec 2, 2021
@ahopkins ahopkins mentioned this pull request Dec 2, 2021
Merged
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
@Varriount @ahopkins @ChihweiLHBird
Refactor environment variable hydration logic. (sanic-org#2321)
c6ac735 
- Refactor environment variable hydration logic to be less nested. This allows possible future extension of the hydration logic.
- Fix a spelling mistake in `load_environment_vars` docstring.

Co-authored-by: Adam Hopkins <admhpkns@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

@prryplatypus prryplatypus prryplatypus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Varriount @ahopkins @prryplatypus