Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 21.9.2 #2313

Merged
merged 6 commits into from Nov 17, 2021
Merged

Merge release 21.9.2 #2313

merged 6 commits into from Nov 17, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Nov 17, 2021

As pointed out by @prryplatypus the v21.9.2 branch originally did not support another config style:

class MyConfig(sanic.config.Config):
    FALLBACK_ERROR_FORMAT = "json"


app = sanic.Sanic("app")
app.config = MyConfig()

I added that into the branch there, and this PR is the mergeback.

ahopkins and others added 5 commits November 16, 2021 23:08
…messages (#2268)

* Make all new connections start in IDLE stage, and switch to REQUEST stage only once any bytes are received from client. This makes new connections without any request obey keepalive timeout rather than request timeout like they currently do.

* Revert typo

* Remove request timeout endpoint test which is no longer working (still tested by mocking). Fix mock timeout test setup.

Co-authored-by: L. Karkkainen <tronic@users.noreply.github.com>
@ahopkins ahopkins marked this pull request as ready for review November 17, 2021 07:12
@ahopkins ahopkins requested a review from a team as a code owner November 17, 2021 07:12
@ahopkins
Copy link
Member Author

Thanks. I'll get this out tonight.

@codeclimate
Copy link

codeclimate bot commented Nov 17, 2021

Code Climate has analyzed commit b477447 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (86% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (0.0% change).

View more on Code Climate.

@ahopkins ahopkins merged commit 0860bfe into main Nov 17, 2021
@ahopkins ahopkins deleted the merge-release-21.9.2 branch November 17, 2021 17:36
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants