Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy error type for async get function in HTTPMethodView #2916

Open
1 task done
FirePanda169 opened this issue Feb 14, 2024 · 2 comments
Open
1 task done

mypy error type for async get function in HTTPMethodView #2916

FirePanda169 opened this issue Feb 14, 2024 · 2 comments
Labels

Comments

@FirePanda169
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Mypy throws an error overriding the signature of the get method, as it is described only for synchronous execution.

error: Signature of "get" incompatible with supertype "HTTPMethodView"  [override]
note:      Superclass:
note:          Callable[..., Any] | None
note:      Subclass:
note:          def get(self, request: Request[Any, Any]) -> Coroutine[Any, Any, HTTPResponse]

I suggest changing the description of the get method /sanic/views.py to:

get: Union[Callable[..., Any], Coroutine[..., Any], None]

Code snippet

No response

Expected Behavior

No response

How do you run Sanic?

As a script (app.run or Sanic.serve)

Operating System

Linux

Sanic Version

23.12.0

Additional context

No response

@ahopkins
Copy link
Member

ahopkins commented Apr 1, 2024

PR welcome 😉

@decarv
Copy link

decarv commented Apr 10, 2024

That did not solve the problem for me. mypy still complains and I have no idea why.

It works if None is removed from the type definition.

 get: Union[Callable[..., Any], Coroutine[..., Any]]

I cannot explain this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants