Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERVER_EXCEPTION_REPORT signal handler does not get passed app positional, docs discrepancy #2893

Open
1 task done
dhensen opened this issue Jan 8, 2024 · 2 comments
Open
1 task done
Labels

Comments

@dhensen
Copy link

dhensen commented Jan 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Docs say that Event.SERVER_EXCEPTION_REPORT/server.exception.report added in 23.6 get app and exception, but I only get exception:

image

Which, according to you, is wrong? The docs or the code?

Code snippet

No response

Expected Behavior

No response

How do you run Sanic?

Sanic CLI

Operating System

Linux

Sanic Version

23.6

Additional context

No response

@dhensen dhensen added the bug label Jan 8, 2024
@ahopkins
Copy link
Member

ahopkins commented Jan 9, 2024

The docs. I don't think the app is generally passed to any signal. We can probably talk about adding that though.

@dhensen
Copy link
Author

dhensen commented Jan 9, 2024

I could have know the docs are wrong because the code is the truth 😃
For what it's worth: I don't need the app, I just copy pasted app + exception from docs into my function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants