Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASGI websocket must pass thru bytes as is #2644

Closed
ahopkins opened this issue Dec 29, 2022 · 2 comments · Fixed by #2651
Closed

ASGI websocket must pass thru bytes as is #2644

ahopkins opened this issue Dec 29, 2022 · 2 comments · Fixed by #2651
Assignees
@SaidBySolo
Labels
beginner enhancement help wanted LTS
Milestone
23.3

Comments

@ahopkins
Copy link
Member

Originally posted by @Tronic in #2640 (comment)
@ahopkins ahopkins added this to the 23.3 milestone Dec 29, 2022
@SaidBySolo
Copy link
Member

If no one else is working on this issue by next week, I will work this issue. :D

@ahopkins
Copy link
Member Author

it's yours

SaidBySolo added a commit that referenced this issue Jan 8, 2023
@SaidBySolo
fix(websocket): ASGI websocket must pass thru bytes as is
d2a0d7a 
fix #2644
@SaidBySolo SaidBySolo mentioned this issue Jan 8, 2023
Merged
SaidBySolo added a commit that referenced this issue Feb 5, 2023
@SaidBySolo
Merge branch 'main' into fix/gh-2644
636057b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaidBySolo SaidBySolo

Labels
beginner enhancement help wanted LTS
Projects
None yet
Milestone
23.3
Development

Successfully merging a pull request may close this issue.

fix(websocket): ASGI websocket must pass thru bytes as is sanic-org/sanic
2 participants
@ahopkins @SaidBySolo