Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority to register_middleware method #2636

Merged
merged 4 commits into from Dec 19, 2022
Merged

Add priority to register_middleware method #2636

merged 4 commits into from Dec 19, 2022

Conversation

ahopkins
Copy link
Member

Closes #2596

@ahopkins ahopkins requested a review from a team as a code owner December 18, 2022 13:04
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 88.615% // Head: 88.640% // Increases project coverage by +0.025% 🎉

Coverage data is based on head (22f296d) compared to base (911485d).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2636       +/-   ##
=============================================
+ Coverage   88.615%   88.640%   +0.025%     
=============================================
  Files           82        82               
  Lines         6746      6761       +15     
  Branches      1152      1156        +4     
=============================================
+ Hits          5978      5993       +15     
  Misses         529       529               
  Partials       239       239               
Impacted Files Coverage Δ
sanic/app.py 90.070% <100.000%> (+0.234%) ⬆️
sanic/middleware.py 96.969% <100.000%> (+0.195%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sanic/app.py Show resolved Hide resolved
sanic/app.py Show resolved Hide resolved
@ahopkins ahopkins merged commit 2abe66b into main Dec 19, 2022
@ahopkins ahopkins deleted the issue2596 branch December 19, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing priority functionality in app-wide middlware
2 participants