Prevent directory traversion with static files #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2495 +/- ##
=============================================
+ Coverage 87.396% 87.434% +0.038%
=============================================
Files 69 69
Lines 5554 5555 +1
Branches 966 966
=============================================
+ Hits 4854 4857 +3
+ Misses 508 507 -1
+ Partials 192 191 -1
Continue to review full report at Codecov.
|
Tronic
reviewed
Jul 18, 2022
|
Should we consider use async file APIs ( Update: |
ChihweiLHBird
previously approved these changes
Jul 27, 2022
ahopkins
reviewed
Jul 27, 2022
ChihweiLHBird
approved these changes
Jul 28, 2022
ahopkins
added a commit
that referenced
this pull request
Jul 28, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Zhiwei Liang <zhi.wei.liang@outlook.com>
ahopkins
added a commit
that referenced
this pull request
Jul 31, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Zhiwei Liang <zhi.wei.liang@outlook.com>
ahopkins
added a commit
that referenced
this pull request
Jul 31, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Zhiwei Liang <zhi.wei.liang@outlook.com>
ahopkins
added a commit
that referenced
this pull request
Jul 31, 2022
Co-authored-by: Adam Hopkins <adam@amhopkins.com> Co-authored-by: Zhiwei Liang <zhi.wei.liang@outlook.com>
ahopkins
added a commit
that referenced
this pull request
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2478 and (maybe?) #2477