Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests for sanic-routing changes #2405

Merged
merged 4 commits into from Mar 23, 2022
Merged

Conversation

ahopkins
Copy link
Member

Recent changes in sanic-routing throw a different error on a bad path parameter declaration.

@ahopkins ahopkins requested review from a team as code owners February 24, 2022 14:17
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2405 (49c6176) into main (0030425) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #2405   +/-   ##
=========================================
  Coverage   87.243%   87.243%           
=========================================
  Files           60        60           
  Lines         5017      5017           
  Branches       904       904           
=========================================
  Hits          4377      4377           
  Misses         468       468           
  Partials       172       172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0030425...49c6176. Read the comment docs.

prryplatypus
prryplatypus previously approved these changes Mar 3, 2022
@ahopkins ahopkins merged commit 6e0a687 into main Mar 23, 2022
@ahopkins ahopkins deleted the sanic-routing-validation branch March 23, 2022 11:43
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants