Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update websockets dependency for security remediation #2367

Closed
sjsadowski opened this issue Jan 11, 2022 · 2 comments · Fixed by #2366
Closed

Update websockets dependency for security remediation #2367

sjsadowski opened this issue Jan 11, 2022 · 2 comments · Fixed by #2366
Assignees
@sjsadowski
Labels
urgent

Comments

@sjsadowski
Copy link
Contributor

Describe the bug
Websockets 9.0.x has a security issue with remediation introduced in 9.1

Additional context
Closed by #2366
@sjsadowski sjsadowski self-assigned this Jan 11, 2022
@sjsadowski sjsadowski linked a pull request Jan 11, 2022 that will close this issue
fix: websocket dependency for websockets 9.1 security fix #2366
Merged
@ahopkins
Copy link
Member

Can you add a link to release notes here?

@ChihweiLHBird
Copy link
Member

This issue was completed as we now have websockets>=10.0 in the setup.py file in both main and LTS branches.

sanic/setup.py

Line 92 in d404116

"websockets>=10.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjsadowski sjsadowski

Labels
urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: websocket dependency for websockets 9.1 security fix sanic-org/sanic
3 participants
@ahopkins @sjsadowski @ChihweiLHBird